Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web): sketch layer UI implementation #855

Merged
merged 30 commits into from
Jan 16, 2024
Merged

chore(web): sketch layer UI implementation #855

merged 30 commits into from
Jan 16, 2024

Conversation

mkumbobeaty
Copy link
Contributor

@mkumbobeaty mkumbobeaty commented Dec 9, 2023 •
edited
Loading

Overview

What I've done

  • Create Sketch layer step I UI
  • Implemented functionality to add the sketch layer

What I haven't done

How I tested

Which point I want you to review particularly

Memo

mkumbobeaty and others added 13 commits November 20, 2023 08:13
@netlify Netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

✅ Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 67bd668
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65a622d43428630008f16a3e
😎 Deploy Preview https://deploy-preview-855--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Dec 9, 2023
@mkumbobeaty mkumbobeaty changed the title Chore/sketch layer chore(web): sketch layer UI implementation Dec 9, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

Attention: 492 lines in your changes are missing coverage. Please review.

Comparison is base (76ada0e) 26.04% compared to head (67bd668) 25.98%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
- Coverage   26.04%   25.98%   -0.07%     
==========================================
  Files        1653     1657       +4     
  Lines      183076   183520     +444     
  Branches     3890     3894       +4     
==========================================
+ Hits        47679    47680       +1     
- Misses     134308   134751     +443     
  Partials     1089     1089
Flag Coverage Δ
web 24.30% <0.20%> (-0.08%) ⬇️
web-beta 24.30% <0.20%> (-0.08%) ⬇️
web-classic 24.30% <0.20%> (-0.08%) ⬇️
web-utils 24.30% <0.20%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/mantle/types/index.ts 100.00% <100.00%> (ø)
...b/src/beta/components/fields/SelectField/index.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/map/LeftPanel/GroupField/index.tsx 0.00% <0.00%> (ø)
.../beta/features/Editor/tabs/map/LeftPanel/index.tsx 0.00% <0.00%> (ø)
...s/Editor/DataSourceManager/DelimitedText/index.tsx 0.00% <0.00%> (ø)
...res/Editor/DataSourceManager/ThreeDTiles/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useLeftPanel.tsx 0.00% <0.00%> (ø)
...features/Editor/DataSourceManager/Common/index.tsx 0.00% <0.00%> (ø)
...res/Editor/DataSourceManager/VectorTiles/index.tsx 0.00% <0.00%> (ø)
...atures/Editor/DataSourceManager/WmsTiles/index.tsx 0.00% <0.00%> (ø)
... and 11 more

... and 2 files with indirect coverage changes

@mkumbobeaty mkumbobeaty marked this pull request as ready for review December 22, 2023 08:56
@mkumbobeaty mkumbobeaty removed the request for review from pyshx December 22, 2023 08:57
@mkumbobeaty mkumbobeaty merged commit 9b9d4bc into main Jan 16, 2024
15 of 16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/sketch-layer branch January 16, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airslice airslice airslice approved these changes

@keiya01 keiya01 keiya01 approved these changes

@jashanbhullar jashanbhullar Awaiting requested review from jashanbhullar

Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkumbobeaty @airslice @keiya01 @KaWaite @nina992